application: sdp: mspi: Ipc Hrt Connection #19449

mif1-nordic · 2024-12-11T15:50:41Z

Depends on patch #20057

CLAassistant · 2024-12-11T15:50:50Z

All committers have signed the CLA.

NordicBuilder · 2024-12-11T15:51:45Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-12-11T15:55:11Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 56

Inputs:

Sources:

sdk-nrf: PR head: 85a040283aff5bc473e85b2b0e845cd237beccbf

more details

sdk-nrf:

PR head: 85a040283aff5bc473e85b2b0e845cd237beccbf
merge base: 1c36f9c6163f8b4f2b8d94693243b78da5465fdd
target head (main): 3daaaad74e03a8f5d530a4e1079a8c40063fca7b
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (8)

applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── boards
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuflpr.conf
│  │  │  ├── src
│  │  │  │  ├── hrt
│  │  │  │  │  ├── hrt.c
│  │  │  │  │  ├── hrt.h
│  │  │  │  │  │ hrt.s
│  │  │  │  │ main.c
cmake
│  │ sdp.cmake
drivers
│  ├── mspi
│  │  │ mspi_nrfe.c
include
│  ├── drivers
│  │  ├── mspi
│  │  │  │ nrfe_mspi.h

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
❌ Integration tests
- ✅ test-sdk-audio
- ✅ desktop52_verification
- ✅ test-fw-nrfconnect-boot
- ✅ test-fw-nrfconnect-apps
- ✅ test_ble_nrf_config
- ✅ test-fw-nrfconnect-ble_mesh
- ✅ test-fw-nrfconnect-ble_samples
- ✅ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nfc
- ❌ test-fw-nrfconnect-nrf-iot_libmodem-nrf
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_samples
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m
- ✅ doc-internal
- ✅ test-fw-nrfconnect-nrf-iot_thingy91
- ✅ test-fw-nrfconnect-nrf_crypto
- ✅ test-fw-nrfconnect-rpc
- ✅ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-tfm
- ✅ test-fw-nrfconnect-thread
- ✅ test-fw-nrfconnect-zigbee
- ✅ test-sdk-find-my
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ❌ test-fw-nrfconnect-nrf-iot_positioning
- ✅ test-sdk-sidewalk
- ✅ test-sdk-wifi
- ✅ test-low-level
- ✅ test-sdk-pmic-samples
- ✅ test-sdk-mcuboot
- ✅ test-sdk-dfu
- ✅ test-fw-nrfconnect-ps
- ✅ test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

magp-nordic

Your commit needs a description and a sign-off (I do not see it right know). Also, it should probably be divided into more commits based on directory that you're changing (with exception to changes in drivers and include/drivers, they can be in the same commit).

applications/sdp/mspi/CMakeLists.txt

applications/sdp/mspi/src/hrt/hrt.c

applications/sdp/mspi/src/main.c

applications/sdp/mspi/src/hrt/hrt.c

applications/sdp/mspi/src/main.c

drivers/mspi/mspi_nrfe.c

scripts/twister/alt/zephyr/tests/drivers/mspi/api/testcase.yaml

snippets/sdp/mspi/flpr.conf

applications/sdp/mspi/src/hrt/hrt.c

applications/sdp/mspi/src/main.c

include/drivers/mspi/nrfe_mspi.h

snippets/sdp/mspi/soc/nrf54l15_cpuapp.overlay

applications/sdp/mspi/src/main.c

applications/sdp/mspi/src/hrt/hrt.c

applications/sdp/mspi/src/main.c

applications/sdp/mspi/src/hrt/hrt.c

scripts/twister/alt/zephyr/tests/drivers/mspi/api/testcase.yaml

applications/sdp/mspi/src/main.c

NordicBuilder · 2025-01-15T12:54:59Z

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

jaz1-nordic

Some nit picks. And still clang failures.

applications/sdp/mspi/src/hrt/hrt.c

tejlmand · 2025-01-16T08:39:12Z

@mif1-nordic The first 3 commits in this PR is identical to #19877.

When creating multiple PRs which contains identical commits, then please make it very clear which commits should be reviewed in which PR, and in the PR where they shouldn't be reviewed, then squash those commits and make a commit message like:

Do not review here, please review in PR #19877

NordicBuilder · 2025-01-16T16:52:58Z

Memory footprint analysis revealed the following potential issues

sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 912194[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: RAM size increased by 1152[B] in comparison to the main[1c36f9c] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 1152[B] in comparison to the main[1c36f9c] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.debug[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 1152[B] in comparison to the main[1c36f9c] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 821134[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: RAM size increased by 1152[B] in comparison to the main[1c36f9c] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-19449/56)

kobj-types-enum.h was generated after VPR asm_gen, added kobj-types-enum.h as dependence for asm_gen. Signed-off-by: Michal Frankiewicz <[email protected]>

added mode support for SINGLE,QUAD,QUAD_1_4_4,QUAD_1_1_4 and custom Ipc mspi structures Signed-off-by: Michal Frankiewicz <[email protected]> Signed-off-by: Jakub Zymelka <[email protected]>

Added reactions to all mspi Ipc messages but NRFE_MSPI_TXRX and NRFE_MSPI_TX. The data is stored in local structures for later use. Signed-off-by: Michal Frankiewicz <[email protected]>

Added MSPI_TX reaction to NRFE_MSPI_TXRX and NRFE_MSPI_TX. Added HRT mspi TX functionality. Signed-off-by: Michal Frankiewicz <[email protected]>

github-actions bot added the manifest label Dec 11, 2024

NordicBuilder added manifest-zephyr DNM labels Dec 11, 2024

mif1-nordic force-pushed the HRT_Config branch 5 times, most recently from 4a5d77c to c2b4727 Compare December 16, 2024 09:27

mif1-nordic marked this pull request as ready for review December 16, 2024 09:52

mif1-nordic requested review from a team as code owners December 16, 2024 09:52

magp-nordic reviewed Dec 16, 2024

View reviewed changes

masz-nordic reviewed Dec 16, 2024

View reviewed changes

mif1-nordic force-pushed the HRT_Config branch from c2b4727 to 8b75e8b Compare December 17, 2024 12:15

masz-nordic reviewed Dec 17, 2024

View reviewed changes

applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved

masz-nordic reviewed Dec 17, 2024

View reviewed changes

applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved

jaz1-nordic reviewed Dec 17, 2024

View reviewed changes

jaz1-nordic requested changes Dec 17, 2024

View reviewed changes

applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved

applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved

applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved

jaz1-nordic reviewed Dec 17, 2024

View reviewed changes

applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved

nrfconnect deleted a comment from masz-nordic Dec 17, 2024

nrfconnect deleted a comment from jaz1-nordic Dec 17, 2024

magp-nordic reviewed Dec 17, 2024

View reviewed changes

magp-nordic reviewed Dec 18, 2024

View reviewed changes

applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 15, 2025

NordicBuilder removed manifest-zephyr DNM labels Jan 15, 2025

masz-nordic requested a review from jaz1-nordic January 15, 2025 12:39

mif1-nordic force-pushed the HRT_Config branch 5 times, most recently from 38b4f32 to 20498de Compare January 15, 2025 14:47

jaz1-nordic reviewed Jan 15, 2025

View reviewed changes

applications/sdp/mspi/src/hrt/hrt.c Show resolved Hide resolved

applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved

applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved

applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved

mif1-nordic force-pushed the HRT_Config branch 2 times, most recently from ca1f61b to 57c9d5f Compare January 15, 2025 15:29

mif1-nordic force-pushed the HRT_Config branch 4 times, most recently from 6319f72 to 7f5115f Compare January 16, 2025 14:56

mif1-nordic force-pushed the HRT_Config branch from 7f5115f to 99ecfc4 Compare January 17, 2025 07:40

mif1-nordic mentioned this pull request Jan 17, 2025

Ipc reduced structures #19877

Open

mif1-nordic force-pushed the HRT_Config branch 4 times, most recently from 2405af4 to 1339c7b Compare January 22, 2025 08:51

mif1-nordic and others added 4 commits January 23, 2025 16:30

cmake: Fixed mspi.h include error

b6ab25f

kobj-types-enum.h was generated after VPR asm_gen, added kobj-types-enum.h as dependence for asm_gen. Signed-off-by: Michal Frankiewicz <[email protected]>

drivers: mspi: Mode and structures

6f5c33e

added mode support for SINGLE,QUAD,QUAD_1_4_4,QUAD_1_1_4 and custom Ipc mspi structures Signed-off-by: Michal Frankiewicz <[email protected]> Signed-off-by: Jakub Zymelka <[email protected]>

applications: sdp: mspi: Ipc communication reaction

5b8af61

Added reactions to all mspi Ipc messages but NRFE_MSPI_TXRX and NRFE_MSPI_TX. The data is stored in local structures for later use. Signed-off-by: Michal Frankiewicz <[email protected]>

application: sdp: mspi: Hrt data transfer

85a0402

Added MSPI_TX reaction to NRFE_MSPI_TXRX and NRFE_MSPI_TX. Added HRT mspi TX functionality. Signed-off-by: Michal Frankiewicz <[email protected]>

mif1-nordic force-pushed the HRT_Config branch from 1339c7b to 85a0402 Compare January 23, 2025 15:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

application: sdp: mspi: Ipc Hrt Connection #19449

application: sdp: mspi: Ipc Hrt Connection #19449

mif1-nordic commented Dec 11, 2024 •

edited

Loading

CLAassistant commented Dec 11, 2024 •

edited

Loading

NordicBuilder commented Dec 11, 2024 •

edited

Loading

NordicBuilder commented Dec 11, 2024 •

edited

Loading

magp-nordic left a comment •

edited

Loading

NordicBuilder commented Jan 15, 2025

jaz1-nordic left a comment •

edited

Loading

tejlmand commented Jan 16, 2025

NordicBuilder commented Jan 16, 2025 •

edited

Loading

application: sdp: mspi: Ipc Hrt Connection #19449

Are you sure you want to change the base?

application: sdp: mspi: Ipc Hrt Connection #19449

Conversation

mif1-nordic commented Dec 11, 2024 • edited Loading

CLAassistant commented Dec 11, 2024 • edited Loading

NordicBuilder commented Dec 11, 2024 • edited Loading

NordicBuilder commented Dec 11, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

magp-nordic left a comment • edited Loading

Choose a reason for hiding this comment

NordicBuilder commented Jan 15, 2025

jaz1-nordic left a comment • edited Loading

Choose a reason for hiding this comment

tejlmand commented Jan 16, 2025

NordicBuilder commented Jan 16, 2025 • edited Loading

Memory footprint analysis revealed the following potential issues

mif1-nordic commented Dec 11, 2024 •

edited

Loading

CLAassistant commented Dec 11, 2024 •

edited

Loading

NordicBuilder commented Dec 11, 2024 •

edited

Loading

NordicBuilder commented Dec 11, 2024 •

edited

Loading

magp-nordic left a comment •

edited

Loading

jaz1-nordic left a comment •

edited

Loading

NordicBuilder commented Jan 16, 2025 •

edited

Loading